Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UtteranceQueue to be parameteric to the Type of its announcer #106

Closed
zepumph opened this issue Mar 2, 2023 · 2 comments
Closed

UtteranceQueue to be parameteric to the Type of its announcer #106

zepumph opened this issue Mar 2, 2023 · 2 comments

Comments

@zepumph
Copy link
Member

zepumph commented Mar 2, 2023

@chrisklus and I found that it would be nice to have UtteranceQueue have a parametric typescript type that was the actual Announcer type. THis way the announcer Property would have the right type associated with it for access. This is valuable for some number suite cases where we pass through utterance queues and want to have access to particular announcer subtype methods.

@zepumph zepumph self-assigned this Mar 2, 2023
zepumph added a commit that referenced this issue Mar 2, 2023
@zepumph
Copy link
Member Author

zepumph commented Mar 2, 2023

@chrisklus is this helpful for you? Now you can do something like new UtteranceQueue<NumberSuiteAnnouncer>.

@chrisklus
Copy link
Contributor

Your commit looks great! This is working really nicely over in phetsims/number-suite-common#58. Thanks! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants