share credits between vector-addition and vector-addition-equations, #98

phetsims · Oct 23, 2019 · 0813cb1 · 0813cb1
1 parent 0a762f8
commit 0813cb1
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/js/common/VectorAdditionConstants.js b/js/common/VectorAdditionConstants.js
@@ -46,6 +46,15 @@ define( require => {
 
   const VectorAdditionConstants = {
 
+    // Shared by vector-addition-main.js and its derivatives (vector-addition-equations-main.js)
+    // See https://github.com/phetsims/vector-addition/issues/98
+    CREDITS: {
+      leadDesign: 'Michael Dubson, Amy Rouinfar',
+      softwareDevelopment: 'Brandon Li, Martin Veillette, Chris Malley (PixelZoom, Inc.)',
+      team: 'Diana L\u00f3pez Tavares, Amanda McGarry, Ariel Paul, Kathy Perkins',
+      qualityAssurance: 'Katie Woessner'
+    },
+
     //----------------------------------------------------------------------------------------
     // ScreenViews
 

diff --git a/js/vector-addition-main.js b/js/vector-addition-main.js
@@ -16,27 +16,24 @@ define( require => {
   const Sim = require( 'JOIST/Sim' );
   const SimLauncher = require( 'JOIST/SimLauncher' );
   const Tandem = require( 'TANDEM/Tandem' );
+  const VectorAdditionConstants = require( 'VECTOR_ADDITION/common/VectorAdditionConstants' );
 
   // strings
   const vectorAdditionTitleString = require( 'string!VECTOR_ADDITION/vector-addition.title' );
 
-  const options = {
-    credits: {
-      leadDesign: 'Michael Dubson, Amy Rouinfar',
-      softwareDevelopment: 'Brandon Li, Martin Veillette, Chris Malley (PixelZoom, Inc.)',
-      team: 'Diana L\u00f3pez Tavares, Amanda McGarry, Ariel Paul, Kathy Perkins',
-      qualityAssurance: 'Katie Woessner'
-    }
-  };
-
   SimLauncher.launch( () => {
+
     const screens = [
       new Explore1DScreen( Tandem.rootTandem.createTandem( 'explore1DScreen' ) ),
       new Explore2DScreen( Tandem.rootTandem.createTandem( 'explore2DScreen' ) ),
       new LabScreen( Tandem.rootTandem.createTandem( 'labScreen' ) ),
       new EquationsScreen( Tandem.rootTandem.createTandem( 'equationsScreen' ) )
     ];
-    const sim = new Sim( vectorAdditionTitleString, screens, options );
+
+    const sim = new Sim( vectorAdditionTitleString, screens, {
+      credits: VectorAdditionConstants.CREDITS
+    } );
+
     sim.start();
   } );
 } );