Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master Checklist #1

Closed
84 of 94 tasks
samreid opened this issue Oct 6, 2017 · 11 comments
Closed
84 of 94 tasks

Master Checklist #1

samreid opened this issue Oct 6, 2017 · 11 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Oct 6, 2017

Wave Interference Port Master Checklist

Design

  • Sim folder and design doc created (Date: 10/05/2017)
  • Legacy sim docs/info gathered
    • Sim suggestions doc reviewed
    • Unfuddle tickets reviewed
  • Learning goals and standards identified (Date: 10/19/2017)
  • Design concept complete (Date: 03/08/2018)
  • Wireframes complete (Date: 03/09/2018)
  • Mockups complete (Date: 05/16/2018)
    • Mockups checked for colorblind and greyscale
  • Features for PhET-iO discussion
  • Interviews complete (Date: 12/11/18)
    • Results reported to team
    • Notes pasted into design doc
    • Back-up of interviews
  • Lead designer "sign off" (Date: 12/09/2018)
    • Performance acceptable
    • Carefully review ?showPointerAreas
    • No new feature requests
  • Pre-publication items
  • Post-publication items
    • Add to Edmodo
    • Add to Gooru, remove legacy version (signed in as phethelp)
  • Deliver to Legends of Learning
  • Sim primer (create issue, publish ideally within 1 month of live sim) - Create Sim Primer #337
  • Hold postmortem if applicable (Date: //)

Implementation

  • Repository created (Date: 10/05/2017)
    • Simulation added to responsible_dev.md
    • simula-rasa used to create project skeleton
    • README.md created using grunt unpublished-readme
    • Collaborators added (such as QA team, designers, etc)
    • standard GitHub label set applied
    • repository added to chipper/data/ filesr
    • Port existing strings (IF ANY) and commit to the GitHub repo (auto-ported strings from Java and Flash sims can
      be found in babel/autoport). The strings should be deleted from babel/autoport and @jbphet should immediately be asked. At Dev Meeting Jan 31, 2019 we decided we are no longer doing this step.
  • Development started (Date: 10/05/2017)
  • Sim is "feature complete" (Date: 1/15/2017 for 1.0 features, Diffraction screen not complete)
  • Code review completed (Date: 12/19/18)
  • Pre-publication items
  • Published (Date: 1/30/2019)
    • README.md updated using grunt published-readme (in master and release branch)
    • Mark the sim as published in responsible_dev.md

QA

  • Legacy sim tested for bugs; issues reported in repo
  • Dev testing started (Date: 12/12/2018)
  • Dev testing complete (Date: 01/23/2019)
  • First RC published (Date: 01/28/2019)
  • RC testing completed (Date: 01/29/2019)

Wave Interference 2.0

Design

Implementation

QA

  • Dev testing started (Date: 05/23/2019)
  • Dev testing complete (Date: 08/06/2019)
  • First RC published (Date: 08/13/2019)
  • RC testing completed (Date: 09/18/2019)
@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 18, 2018

It looks like this checklist has not been maintained by @samreid @arouinfar or @KatieWoe. I've started code review in #259, and this issue is not providing info needed to complete that checklist. E.g., whether the sim is feature complete, whether performance signoff has occured, whether pointerAreas have been reviewed, behavior with stringTest, ...

@KatieWoe
Copy link
Contributor

I was unaware of this. QA section updated.

@samreid samreid mentioned this issue Dec 18, 2018
@arouinfar
Copy link
Contributor

The checklist is now up to date, but reflects the progress for the screens which will be included in the 1.0 release. Leaving assigned to @ariel-phet to add a section for the 2.0 release.

@arouinfar arouinfar removed their assignment Dec 18, 2018
@pixelzoom
Copy link
Contributor

Code review completed today, see #259, so I checked it off here in the master checklist.

This was referenced Jan 30, 2019
@arouinfar arouinfar self-assigned this Feb 1, 2019
@arouinfar
Copy link
Contributor

@ariel-phet the remaining items are yours. We also need an additional, pared-down checklist for 2.0.

@arouinfar arouinfar removed their assignment Feb 4, 2019
@samreid
Copy link
Member Author

samreid commented Sep 23, 2019

@arouinfar or @ariel-phet any other pre-publication items to do before I publish wave-interference 2.0? I noticed that the screenshot in the branch already shows the diffraction screen:
https://github.com/phetsims/wave-interference/blob/7ebcb1ae70106ca93d7d430d4a6cf77f23a0fa3b/assets/wave-interference-screenshot.png

@arouinfar
Copy link
Contributor

arouinfar commented Sep 23, 2019

@samreid I don't think there's anything blocking 2.0.

I will make a 2.0 section of the checklist covering the design issues as I make the sim live. We should probably do the same for Implementation and QA too.

@samreid
Copy link
Member Author

samreid commented Sep 23, 2019

@samreid I don't think there's anything blocking 1.0.

I presume you meant there's nothing blocking today's publication of 2.0. Please correct me if this is wrong.

@arouinfar
Copy link
Contributor

@samreid sorry, yes, I meant 2.0. 🤦‍♀

I've edited the comment.

@samreid
Copy link
Member Author

samreid commented Sep 23, 2019

Wave Interference 2.0 is published, @arouinfar can you please address post-publication steps?

@arouinfar
Copy link
Contributor

The remaining unchecked items are not applicable (e.g. post-mortem, PhET-iO discussion), so this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants