Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odd grouping of UI components #262

Closed
pixelzoom opened this issue Dec 18, 2018 · 3 comments
Closed

odd grouping of UI components #262

pixelzoom opened this issue Dec 18, 2018 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 18, 2018

Related to #259 code review, noticed in #261.

In the Waves screen, when the speaker radio button is selected, the control panel looks like this:

screenshot_944

Having the bottom 4 UI components (1 checkbox, 3 radio buttons) grouped together makes them look related, when in fact the Graphs checkbox is unrelated. Consider adjusting the spacing, or add a separator, to make the grouping clear.

@pixelzoom
Copy link
Contributor Author

Note that decisions made here may impact #283.

@samreid
Copy link
Member

samreid commented Dec 21, 2018

Spacing was adjusted in another issue, it looks like this now:

image

@arouinfar do you recommend further changes to segregate the radio button group from the checkbox?

@arouinfar
Copy link
Contributor

@samreid I like the added negative space. I don't have any further UI changes to recommend, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants