Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more vertical space between checkboxes and radio buttons? #261

Closed
pixelzoom opened this issue Dec 18, 2018 · 3 comments
Closed

add more vertical space between checkboxes and radio buttons? #261

pixelzoom opened this issue Dec 18, 2018 · 3 comments
Assignees
@arouinfar
Labels
design:polish

Comments

@pixelzoom
Copy link
Contributor

Related to code review #259, pointer areas.

There's plenty of vertical space, why is there so little spacing between vertically stacked radio buttons and checkboxes?

screenshot_943
@pixelzoom pixelzoom mentioned this issue Dec 18, 2018
Closed
@samreid samreid mentioned this issue Dec 18, 2018
Closed
@arouinfar
Copy link
Contributor

Thanks for the suggestion @pixelzoom. I agree the checkboxes and aqua radio buttons are a bit tighter than necessary. @samreid can you add a px or two of padding between these components?

@arouinfar arouinfar assigned samreid and unassigned arouinfar Dec 18, 2018
samreid added a commit that referenced this issue Dec 20, 2018
@samreid
Increase spacing between checkboxes and radio buttons, see #261
6ab45c3
@samreid
Copy link
Member

samreid commented Dec 20, 2018

I bumped up the spacing, @arouinfar can you please review? Close if all is well.

@samreid samreid assigned arouinfar and unassigned samreid Dec 20, 2018
@arouinfar
Copy link
Contributor

Looks nice @samreid, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
design:polish
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @pixelzoom @arouinfar