Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model.md issues #263

Closed
pixelzoom opened this issue Dec 18, 2018 · 3 comments
Closed

model.md issues #263

pixelzoom opened this issue Dec 18, 2018 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

Related to code review #259, where @samreid said:

I recommend to start with the documentation:
wave-interference/doc/implementation-notes.md
wave-interference/doc/model.md

Formatting of model.md is jacked, and it's unclear whether it was reviewed by @arouinfar.

@pixelzoom pixelzoom self-assigned this Dec 18, 2018
pixelzoom added a commit that referenced this issue Dec 18, 2018
pixelzoom added a commit that referenced this issue Dec 18, 2018
pixelzoom added a commit that referenced this issue Dec 18, 2018
@samreid samreid mentioned this issue Dec 18, 2018
@pixelzoom
Copy link
Contributor Author

@samreid please review the formatting changes that I made above.

@arouinfar please review to verify that this contains all of the info that you'd like to communicate to a nontechnical audience.

@pixelzoom pixelzoom assigned samreid and arouinfar and unassigned pixelzoom Dec 18, 2018
@samreid
Copy link
Member

samreid commented Dec 18, 2018

Formatting changes look good, self-unassigning but leaving @arouinfar assigned to make sure the content is complete and correct.

@samreid samreid removed their assignment Dec 18, 2018
@arouinfar
Copy link
Contributor

Looks good to me. Thanks @pixelzoom @samreid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants