Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confusion between "emitter" vs AXON/Emitter #272

Closed
pixelzoom opened this issue Dec 18, 2018 · 3 comments
Closed

confusion between "emitter" vs AXON/Emitter #272

pixelzoom opened this issue Dec 18, 2018 · 3 comments
Assignees
@pixelzoom
Labels
dev:code-review status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

Related to code review #259.

I found the use of "emitter" in a non-AXON context to be confusing, in type names (EmitterNode) and documentation ("for each emitter"). The confusion could be avoided by either using a synonym, or clarifying in the documentation.
@samreid
Copy link
Member

samreid commented Dec 18, 2018

If you think of a better name over the course of the review, I'd love to hear it!

samreid added a commit that referenced this issue Dec 19, 2018
@samreid
Rename "emitter" => "wave generator", see #269 and #272
1c87dd4
@samreid
Copy link
Member

samreid commented Dec 19, 2018

Proposed renaming committed, please review.

@samreid samreid assigned pixelzoom and unassigned samreid Dec 19, 2018
pixelzoom added a commit that referenced this issue Dec 19, 2018
@pixelzoom
remove REVIEW comments, #272
2251564 
Signed-off-by: Chris Malley <cmalley@pixelzoom.com>
@pixelzoom
Copy link
Contributor Author

👍 Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom