inconsistent naming of Enumerations

[pixelzoom]

Related to code review #259.

There are currently 2 patterns used to name Enumerations:

(1) 'Enum' suffix: BarrierTypeEnum, PlaySpeedEnum

(2) 'Type' suffix: ApertureType, SoundViewType, SceneType, ViewType, WaveSpatialType, WaveTemporalType

I don't have a preference on which pattern is used, but it would be nice to pick one.

[pixelzoom]

And I don't think we need to necessarily be consist across all sims, just within a sim.

[samreid]

It seems it would be best for this sim to change:

BarrierTypeEnum => BarrierType
PlaySpeedEnum => PlaySpeedType

[pixelzoom]

I guess I do have a preference. 'Type' is misleading. These are not types, they are enumerations. So I think 'Enum' is the appropriate suffix.

[samreid]

So will several of these end with TypeEnum? For instance, ApertureEnum sounds incorrect because it doesn't enumerate apertures, it enumerates aperture types.

[pixelzoom]

If it makes life easier, I'm OK with 'Type' suffix.

[samreid]

Do you prefer ApertureType or ApertureTypeEnum?

[pixelzoom]

ApertureType if you choose to use 'Type' suffix; ApertureTypeEnum if you choose to use 'Enum' suffix.

[samreid]

Enum suffix added, please review.

[pixelzoom]

👍 Closing.