Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaveGeneratorNode API is too broad #286

Closed
pixelzoom opened this issue Dec 19, 2018 · 2 comments
Closed

WaveGeneratorNode API is too broad #286

pixelzoom opened this issue Dec 19, 2018 · 2 comments
Assignees
@pixelzoom
Labels
dev:code-review status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 19, 2018 •
edited
Loading

Related to code review #259:

  • Is there any unnecessary coupling? (e.g., by passing large objects to constructors, or exposing unnecessary properties/functions)

The constructor API for WaveGeneratorNode and its subclasses is too broad. Notes:

  • WaveGeneratorNode does not use @param {WavesScreenModel} model, that parameter can be deleted.
  • LighterGeneratorNode does not require the entire model, only model.lightScene.
  • SoundGeneratorNode does not require the entire model, only model.soundScene
  • WaterGeneratorNode does not require the entire model, only model.waterScene
@samreid samreid mentioned this issue Dec 19, 2018
Closed
samreid added a commit that referenced this issue Dec 29, 2018
@samreid
Pass scenes where appropriate and remove unused parameter, see #286
738368c
@samreid
Copy link
Member

samreid commented Dec 29, 2018

Proposed fix committed, please review.

@samreid samreid assigned pixelzoom and unassigned samreid Dec 29, 2018
@pixelzoom
Copy link
Contributor Author

👍 Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom