Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should TheoryInterferenceOverlay use red or colorblind red shade? #291

Closed
samreid opened this issue Dec 20, 2018 · 4 comments
Closed

Should TheoryInterferenceOverlay use red or colorblind red shade? #291

samreid opened this issue Dec 20, 2018 · 4 comments

Comments

@samreid
Copy link
Member

samreid commented Dec 20, 2018

We currently show the minima in red and maxima in yellow. During code review #259 @pixelzoom asked if we should use our shade of colorblind red instead of pure red. @arouinfar what do you think?

@pixelzoom
Copy link
Contributor

I brought this up in code review because 'red' on 'black' has historically been a bad combination for some types of colorblindness.

@arouinfar
Copy link
Contributor

Thanks for the suggestion @pixelzoom! Let's use RED_COLORBLIND instead of pure red @samreid.

@arouinfar arouinfar assigned samreid and unassigned arouinfar Dec 20, 2018
@samreid
Copy link
Member Author

samreid commented Dec 29, 2018

Fixed in the preceding commit, @arouinfar do you want to check on phettest? If all is well, please close.

@arouinfar
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants