Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicated array in InterferenceScreenView #293

Closed
pixelzoom opened this issue Dec 21, 2018 · 1 comment
Closed

duplicated array in InterferenceScreenView #293

pixelzoom opened this issue Dec 21, 2018 · 1 comment
Assignees
@pixelzoom
Labels
dev:code-review status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

Related to code review #259, noted while reviewing some other unrelated changes.

In InterferenceScreenView, [ waterSceneRange, soundSceneRange, lightSceneRange ] is repeated 3 times. Factor out into:

const allRanges = [ waterSceneRange, soundSceneRange, lightSceneRange ]
samreid added a commit that referenced this issue Jan 1, 2019
@samreid
Factor out allRanges, see #293
3fd5ade
@samreid samreid assigned pixelzoom and unassigned samreid Jan 1, 2019
@pixelzoom
Copy link
Contributor Author

👍 Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom