Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #37 - hot reload of css files. #40

Conversation

vkomulai
Copy link

@vkomulai vkomulai commented May 4, 2016

I have removed ExtractTextPlugin from package.json and webpack configs, because it doesn't support css hot reloading.

Without it, css hot reload works. This should resolve issue #37 - live reload of css files.

…cause it doesn't support well css hot reloading. Without it, css hot reload works
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 98e48dd on vkomulai:remove-extract-text-plugin-enable-css-reload into * on pheuter:master*.

@pheuter
Copy link
Owner

pheuter commented May 15, 2016

hm, i believe extract-text-webpack-plugin is necessary for css module loading to work properly, particularly when you want to import a css file as classNames. did you test this to see if css styling and class names still work properly?

@vkomulai
Copy link
Author

vkomulai commented May 17, 2016

Yes, I have tested that css still work.

In the attached example I have changes a css class .heading, which is imported in login.js using "import styles from './style.css';" and referenced in the JSX part

Login Page

screen shot 2016-05-17 at 20 20 26

@coveralls
Copy link

coveralls commented May 18, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 48e4aa6 on vkomulai:remove-extract-text-plugin-enable-css-reload into 9cd9a6a on pheuter:master.

@vkomulai vkomulai closed this Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants