Enable links to cell broadcast app #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables links from the settings to the cell broadcast app for configuring the behavior for received cell broadcasts. While most hardware overlays already enabled this setting, it's nothing hardware related, so it makes sense to set here globally for any device. I'll also open a PR in `vendor_hardware_overlay` to remove the setting from all overlays there.
Dunedan
added a commit
to Dunedan/vendor_hardware_overlay
that referenced
this pull request
Mar 15, 2020
This is a follow-up to phhusson/device_phh_treble#163 which is about enabling `config_cellBroadcastAppLinks` for all devices, therefore making it unneccessary to specify it in a hardware overlay as well.
Dunedan
added a commit
to Dunedan/vendor_hardware_overlay
that referenced
this pull request
Mar 15, 2020
This is a follow-up to phhusson/device_phh_treble#163 which is about enabling `config_cellBroadcastAppLinks` for all devices, therefore making it unnecessary to specify it in a hardware overlay as well.
sooti
pushed a commit
to aosp-tissot/device_phh_treble
that referenced
this pull request
Jul 4, 2020
…links Enable links to cell broadcast app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables links from the settings to the cell broadcast app for
configuring the behavior for received cell broadcasts.
While most hardware overlays already enabled this setting, it's nothing
hardware related, so it makes sense to set here globally for any device.
I'll also open a PR in
vendor_hardware_overlayto remove the settingfrom all overlays there.