Build against system libquasselc. #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TC01
added a commit
to TC01/quassel-irssi
that referenced
this pull request
Sep 10, 2016
This is an adapted version of phhusson#10, except it uses the makefile variable SYSTEM_QUASSELC. If SYSTEM_QUASSELC is not set, then quassel-irssi is built and linked against the bundled (via git submodule) copy of libquasselc. If SYSTEM_QUASSELC is set, then quassel-irssi looks for a system-wide copy of libquasselc and attempts to link against it. This also amends the build process slightly to respect LDFLAGS (so we can pass -lquasselc when linking when SYSTEM_QUASSELC is set). There is one quirk, which is that you must set SYSTEM_QUASSELC both when building and installing. I tested that building and loading from irssi works in both cases.
TC01
added a commit
to TC01/quassel-irssi
that referenced
this pull request
Sep 10, 2016
This is an adapted version of phhusson#10, except it uses the makefile variable SYSTEM_QUASSELC. If SYSTEM_QUASSELC is not set, then quassel-irssi is built and linked against the bundled (via git submodule) copy of libquasselc. If SYSTEM_QUASSELC is set, then quassel-irssi looks for a system-wide copy of libquasselc and attempts to link against it. This also amends the build process slightly to respect LDFLAGS (so we can pass -lquasselc when linking when SYSTEM_QUASSELC is set). There is one quirk, which is that you must set SYSTEM_QUASSELC both when building and installing. I tested that building and loading from irssi works in both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the right move for quassel-irssi at the moment, but this demonstrates that libquasselc works.
Perhaps quassel-irssi could optionally use the system libquasselc or the submodules depending on user preference; I'd like to use the system libs for the Debian package.