ro.vendor.product.device is deprecated in API 28 vendors #25
Comments
argraur
changed the title
argraur
added a commit
to argraur/vendor_hardware_overlay
that referenced
this issue
Sep 16, 2018
Old way doesnt work with Pie vendors. Move to universal way of determining Mi 8 See this: phhusson#25 Test: make -j64 treble-overlay-xiaomi-mi8; copy to /system/overlay/; ensure overlay works Signed-off-by: argraur <argraur@gmail.com>
phhusson
pushed a commit
that referenced
this issue
Oct 5, 2018
Old way doesnt work with Pie vendors. Move to universal way of determining Mi 8 See this: #25 Test: make -j64 treble-overlay-xiaomi-mi8; copy to /system/overlay/; ensure overlay works Signed-off-by: argraur <argraur@gmail.com>
electrikjesus
pushed a commit
to BlissRoms/vendor_hardware_overlay
that referenced
this issue
Nov 17, 2018
Old way doesnt work with Pie vendors. Move to universal way of determining Mi 8 See this: phhusson/vendor_hardware_overlay#25 Test: make -j64 treble-overlay-xiaomi-mi8; copy to /system/overlay/; ensure overlay works Signed-off-by: argraur <argraur@gmail.com>
|
Closable, I guess |
|
Sure sir |
|
Ah yeah I forget here. |
osm0sis
added a commit
to osm0sis/AnyKernel3
that referenced
this issue
Oct 29, 2019
- ro.vendor.build.product (from #44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
osm0sis
added a commit
to osm0sis/N5X-6P-BLOD-Workaround-Injector
that referenced
this issue
Oct 29, 2019
- ro.vendor.build.product (from #44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
thanasxda
pushed a commit
to thanasxda/AnyKernel3
that referenced
this issue
Oct 29, 2019
- ro.vendor.build.product (from osm0sis#44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
idkwhoiam322
pushed a commit
to idkwhoiam322/AnyKernel3
that referenced
this issue
Oct 30, 2019
- ro.vendor.build.product (from #44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
zeta96
pushed a commit
to zeta96/AnyKernel3
that referenced
this issue
Oct 31, 2019
- ro.vendor.build.product (from osm0sis#44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
idkwhoiam322
pushed a commit
to idkwhoiam322/AnyKernel3
that referenced
this issue
Nov 1, 2019
- ro.vendor.build.product (from #44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
ArbitraryFox
pushed a commit
to ArbitraryFox/AnyKernel3
that referenced
this issue
Nov 4, 2019
- ro.vendor.build.product (from osm0sis#44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
raphielscape
added a commit
to raphielscape/AnyKernel3
that referenced
this issue
Jan 11, 2020
…dm845 * 'master' of https://github.com/osm0sis/AnyKernel2: tools: update magisk utils to v20.3(20300) stable Should only run in recovery Add apex mount/umount (osm0sis#48) tools: update magisk utils to v20.2(20200) stable tools: update magisk utils to v20.1(20100) stable tools: update to latest busybox (1.31.1) Compiled from my own updated fork: https://github.com/osm0sis/android-busybox-ndk Backend: further fixes for GSIs - ro.vendor.build.product (from osm0sis#44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity Backend: break early on getprop failure fallback when value found Backend: fix getprop and devicecheck for GSIs - add additional prop locations to getprop failure fallback - add vendor props to devicecheck and getprop parsing fallback check to avoid false negatives on GSIs - mask errors from devicecheck getprops as not all of them may exist on GSIs or non-GSIs Signed-off-by: Raphiel Rollerscaperers <rapherion@raphielgang.org>
zeta96
pushed a commit
to zeta96/AnyKernel3
that referenced
this issue
Jan 17, 2020
- ro.vendor.build.product (from osm0sis#44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
zeta96
pushed a commit
to zeta96/AnyKernel3
that referenced
this issue
Jan 17, 2020
- ro.vendor.build.product (from osm0sis#44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
klabit87
pushed a commit
to klabit87/AnyKernel3
that referenced
this issue
Feb 16, 2020
- ro.vendor.build.product (from osm0sis#44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
klabit87
pushed a commit
to klabit87/AnyKernel3
that referenced
this issue
Feb 16, 2020
- ro.vendor.build.product (from osm0sis#44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
klabit87
pushed a commit
to klabit87/AnyKernel3
that referenced
this issue
Feb 16, 2020
- ro.vendor.build.product (from osm0sis#44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
infinity-plus
pushed a commit
to infinity-plus/AnyKernel3
that referenced
this issue
Apr 11, 2020
- ro.vendor.build.product (from osm0sis#44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity
mARk-android
pushed a commit
to mARk-android/AnyKernel3
that referenced
this issue
Jun 30, 2021
…main # By osm0sis (301) and others added support for a11 BringUp GatotKaca Kernel tools: update magisk utils to v22.0(22000) stable Backend: one more umount_all() touch-up README: document replace_line and remove_line global scope AK3+Backend: cleanups, update *_line functions README: document no_block_display=1 AK3: clean up old style tic Backend: add /product and /persist support Backend: clean up old style tic tools: update magisk utils to v21.4(21400) stable Backend: fix apex unmounting during addon.d-v2 Backend: slot detection and mounting fixes tools: update magisk utils to v21.2(21200) stable Backend: mounting improvements Backend: support mounting dynamic partitions from /dev/block/mapper Backend: do apex mounts before /system bind to ensure a working env Backend: fix sloppy/unpredictable `cmd && this || that` statements AK3: unlock blocks before flash to handle post-incremental-OTA cases Makefile: Add genom R Revert "makefile: Support MIUI 12" Revert "anykernel: Insert wlan insmod cmd line" anykernel: Insert wlan insmod cmd line makefile: Support MIUI 12 AK3: allow hiding block display for zips with custom output anykernel: Add willow support README: update boot_signer-dexed.jar naming LICENSE: update boot_signer-dexed.jar naming AK3: update for latest optional binaries Backend: add logical partition block mapper rw support Backend: try to preserve a working /etc/fstab on AOSP Q-based recovery anykernel: Ginkgo only AK3: show final detected target slot/partition tools: update magisk utils to v20.4(20400) beta Backend: don't do remounts for pushing modules in addon.d-v2 anykernel: Squash updates AK3+Backend: fix truncated recovery.log with FlashAfterUpdate Backend: fixes for booted flashing and addon.d-v2 - only do setup_env and restore_env when in recovery to prevent environment/mount issues post-install - use busybox [ for simple integer test to ensure known numerical operator behavior Backend: simplify heredoc usage Backend: support for upcoming recovery addon.d-v2 - for FlashAfterUpdate addon.d-v2 support while in recovery - recovery addon.d-v2 requires /system and /system_root stay mounted Backend: add additional BOOTCLASSPATH entry for /apex mounts Backend: fix /system/bin/* execution on recoveries using LD_CONFIG_FILE tools: update magisk utils to v20.4-ed58cf95(20304) canary - fix lzop detection use-case of magiskboot decompress which was broken in the generic stream refactor AK3+Backend: mount and output fixes - fix case where TWRP has /system_root mountpoint but ROM is non-SAR - fix regression in ui_print when final character is \ Backend: work around some Lineage 17 (AOSP Q) Recovery issues - Lineage 17 Recovery has some problems currently: /system mountpoint in ramdisk, neither /system nor /system_root in fstab (it has / instead, which is useless), ANDROID_ROOT=/system, and no /system_root symlink - /etc is linked to /system/etc so once /system is mounted /etc/fstab is gone and no further simple mount commands will work so move other mounts before /system - /system/bin are the only utilities available on PATH with none at all in /sbin so we need /apex files mounted immediately or no non-busybox commands will work after mounting /system over the recovery's skeleton /system - not all devices have /dev/block/bootdevice symlinks, but at some point "broken recovery is broken" has to apply, so I don't intend to build out full system partition discovery for the SAR mount fallback AK3+Backend: /postinstall and opposite slot awareness for FlashAfterUpdate addon.d-v2 support - for A/B OTAs my FlashAfterUpdate addon.d script requires the zip to know about addon.d-v2 and act accordingly - signify support with #FLASHAFTERUPDATEV2 tag in updater-script to pass whitelist check since the majority of zips will not work correctly Backend: fixes for mounting system on Lineage Recovery - Lineage has a mindboggling: /system_root as mountpoint in ramdisk, neither /system nor /system_root in fstab (it has / instead, which is useless), ANDROID_ROOT=/system, and a possible symlink from /system to /system_root/system - this failure to have a sensible, working fstab triggers the fallback to mounting directly from /dev/block/bootdevice which should exist on all modern devices which would need this SAR fallback - add basic slot support for the fallback mount, since Lineage Recovery also doesn't make symlinks to the active slot partitions Backend: put debugging down where it belongs too Makefile: drop hours Update Makefile Backend: work around ongoing TWRP SAR support fragmentation TWRP now has 3(!) different competing implementations of SAR currently in use by maintainers: 1) /system as mountpoint in ramdisk/fstab and ANDROID_ROOT=/system, and possible symlink from /system_root to /system 2) /system_root as mountpoint in ramdisk/fstab, ANDROID_ROOT=/system_root, and possible symlink from /system to /system_root/system 3) /system_root as mountpoint in ramdisk/fstab, ANDROID_ROOT=/system, and possible symlink from /system to /system_root/system Backend: overdue clean up and refactor - move checks to functions to isolate single-use variables as local - signify globally available variables with capitalization - move setup and mount to functions to mirror umount_all and restore_env - cluster functions by use order (no call should preceed its function) - use short circuit return tests to reduce indentation now that we use functions Makefile: Add vince MIUI Oreo modules: Add system modules support for vince oreo anykernel: Oreo support Backend: fix link restoration post-install README: document do.systemless, update and sync with XDA thread anykernel: add do.systemless AK3+Backend: introduce systemless kernel modules support - with do.systemless prop enabled in anykernel.sh, will push the contents of modules/ to create a simple "ak3-helper" Magisk module, where testing on devices thus far shows it loads early enough that even replacement kernel object .ko modules will get loaded - the ak3-helper module info is populated from the kernel.string and parsed kernel version from the kernel being flashed, and if at boot time a different kernel is detected the module automatically removes itself before being loaded to avoid conflicts - since logical partitions and ext4-dedup on Android 10 now prevent mounting /system or /vendor rw under any circumstances, this feature gives kernel developers back the freedom they had before all this to improve kernel .ko modules, .conf files, etc. with the added bonus of it cleaning up after itself Makefile: Update naming Makefile: Drop lavender aosp pie AK3: add stderr hints for signing debugging AK3: clean up and simplify Magisk patch logic - only repatch when there is an Image* (i.e. don't attempt on ramdisk-only mods) - make sure new ramdisk is already copied before trying to detect Magisk patch state in case it changed - clean up Magisk patch state and exported variables immediately Backend: fix dalvikvm execution in recovery on Android 10 Backend: don't attempt to unmount /system_root when booted - work around booted flashing apps like FKM/EXKM which make /system busy to keep it from being unmounted but can't do the same with /system_root which can lead to sketchy behavior AK3: fix false positive Magisk detection after reset_ak AK3: only attempt to dump .magisk config if patch found AK3: auto kernel patch improvements - also check patch status as part of repack_ramdisk() to avoid any issues if developer is forcing a compression format change - get full Magisk patch status value and extract Magisk config to export correct environment variables for dtb patching AK3: only attempt fallback kernel decompression if format was identified Revert "AnyKernel3: Preserve magisk on Android 9 / Pie" AK3: fix AVBv1 signing on Android 10 AK3: auto split Image.*-dtb to kernel/kernel_dtb + re-patch for Magisk anykernel: lavender newcam Backend: APEX mounts support improvements tools: update magisk utils to v20.3(20300) stable anykernel: Multi lavender anykernel: Universal ginkgo: Update Should only run in recovery Add apex mount/umount (#48) tools: update magisk utils to v20.2(20200) stable ak3-core: Don't abort if no ramdisk found AnyKernel3: Inline ginkgo AnyKernel3: Preserve magisk on Android 9 / Pie AnyKernel3: Add Makefile anykernel: Lavender inline tools: update magisk utils to v20.1(20100) stable tools: update to latest busybox (1.31.1) Compiled from my own updated fork: https://github.com/osm0sis/android-busybox-ndk Backend: further fixes for GSIs - ro.vendor.build.product (from #44) doesn't appear to actually exist in nature, so replace it with ro.product.vendor.device for API 28+ devices, per phhusson/vendor_hardware_overlay#25 - no need to check so many props for getprop parsing fallback check, simply look for ro.build.type which all devices should have in antiquity Backend: break early on getprop failure fallback when value found Backend: fix getprop and devicecheck for GSIs - add additional prop locations to getprop failure fallback - add vendor props to devicecheck and getprop parsing fallback check to avoid false negatives on GSIs - mask errors from devicecheck getprops as not all of them may exist on GSIs or non-GSIs Backend: fix restore_env $bb commands Backend: add /dev/random workaround for recovery README: add note about including new LICENSE file in zips LICENSE: slight clarifications and touch-ups add LICENSE and compliance notices for binary redistribution Backend: rewrite mount logic to properly cover all cases - use $ANDROID_ROOT variable which in TWRP is set to /system_root on properly set up SAR devices and default set it to /system - continue to correct any issues with /system and /system_root mountpoints but backup and restore any symlinks encountered - only mount and umount /data when it is not mounted to begin with to fix MTP issues in TWRP on some devices (thanks @Zackptg5) - refactor tear down into restore_env() function to allow restoring original recovery environment even after abort - add lazy umounts because let's be thorough - remove hacky workaround to avoid /system_root umount when booted since that should be handled by flashing app now Backend: mask error on TWRP devices without /system_root in fstab Backend: support TWRP devices with /system_root in fstab Backend: mounting fixes, simplify ui_printing from files - rename unmount_all to umount_all since it's been bugging me for a while ;) - refactor mountpoint setup into its own function - try mount --move first since /system should already be mounted (thanks @Zackptg5) - refactor reused script to ui_print from files into its own function Backend: fix derp README: cosmetic changes to match xda thread Backend: ensure /system_root umount even if /system is a symlink Backend: attempt to fix system_root setup on oddball device recoveries - TWRP for some devices has /system as a symlink, some do not; apparently some weird devices have /system_root as a symlink (somehow); attempt to fix them all AK3: fix partition detection taking first match on older devices - `test -e` could fail due to unexpanded *'s in $target AK3+Backend: fix multi-line abort outputs AK3: reset_ak: don't remove $ramdisk unless has already been unpacked - running reset_ak before an unpack would remove any included ramdisk files from zip, so only remove if $split_img is detected suggesting an unpack has already occurred README: update for set_perm and set_perm_recursive Example: update to use set_perm_recursive DO NOT MERGE if you have already updated your ramdisk properly for your device AK3: add file/directory attributes functions - from my "Complete Shell Script Flashable Zip Replacement" reference thread: https://forum.xda-developers.com/android/software-hacking/dev-complete-shell-script-flashable-zip-t2934449 Backend: remember we needs them busybox awks README: document supported.patchlevels anykernel: add supported.patchlevels Backend: introduce Android security patch level check, cleanups - checks the supported.patchlevels prop in anykernel.sh and matches against it to prevent users flashing incorrect kernels for patch levels - this is possibly more important than supported.versions now since modern Android doesn't really do point releases anymore, so a patch level is more likely to signify breakage than a version change - supported.patchlevels can be a closed or open-ended range of dates in the format YYYY-MM, e.g. "2019-04 - 2019-06", "2019-04 -" or "- 2019-06" where the last two examples show setting a minimum and maximum, respectively - clean up device and version checks a bit while we're at it README: add caveat about slots + modules Backend: speed up and simplify is_mounted use README: update for optional arch detect AK3: add simple arch detect to optionally support arm + x86 in same zip - for use with broad zips targetting many devices including different architectures - enable support by putting current tools binary contents in tools/arm and adding tools/x86 tools: update magisk utils to v19.4-05658caf(19305) canary Backend: use recovery umount for /vendor Backend: fix getting parent directory on some devices tools: update magisk utils to v19.4-1058aeb0(19302) canary AK3: better living through sed - clean up magiskboot compression type output parsing AK3: fix support for forced uncompressed cpio ramdisk repacks - resolves osm0sis/AnyKernel3@6986821 "IMPORTANT NOTE" 1 tools: update magiskboot to v19.4-ee407472(19301) - resolves osm0sis/AnyKernel3@6986821 "IMPORTANT NOTE" 2, and allows 1 to be supported (via script change in subsequent commit) README: update to emphasize final kernel build product shouldn't be renamed Example: remove more things confusing to new adopters - remove zImage since people were still thinking they needed to rename their kernel build product to zImage to have it work, while actually all filenames are detected and supported automatically, whether it's called zImage, zImage-dtb, Image.gz, Image.gz-dtb, Image.lz4-dtb, whatever (https://github.com/osm0sis/AnyKernel3/blob/7ccf4d62cede0527b7d895a8255f18b9b56046cc/tools/ak3-core.sh#L228); in fact it's extra important it be named correctly now with AK3 using magiskboot so that any appended *-dtb is supported correctly and doesn't get appended multiple times in subsequent flashes - remove pointless patch file examples - add unified tuna variant name just because I feel like it since it's otherwise not a working example anymore AK3: fix signing derp AK3: allow ChromeOS auto-detect, clean up signing, fixes - since magiskboot has built-in detection for the ChromeOS image pre-header signature, allow it to be auto-detected and if futility and signing files are present re-sign automatically (thanks @Zackptg5 for the nudge) - simplify signing and error catching - fix typo breaking ramdisk_recovery partition detection - hide expected stderr for formats where some files may not exist (cmdline for ELF, etc.) Backend: avoid tar complaining when there is no recovery.log - clean up needless $parent stuff - recovery.log will only be in /tmp regardless of $home Backend: only take relevant files for debug .tgz AK3: clean up "OG AK" mode stderr on images with no kernel/ramdisk present AK3: be clear when unpack_ramdisk fails because there is no ramdisk - previously this was failing a bit too spectacularly for my liking since $comp would erroneously get set to "fopen: ramdisk.cpio failed with 2: No such file or directory" - on devices where there is no ramdisk.cpio unless rooted with Magisk this will indicate better to developers working on the device that they should be using "OG AK" mode to avoid trying to unpack a ramdisk which may or may not exist Backend: fix debugging .tgz creation for booted installs - some apps copy the zip to be flashed to the app cache, which would result in the .tgz going either somewhere unknown/inaccessbile to the user or get deleted when the app cleans up after flash, so instead send to /sdcard if the device is booted to Android AK3: also make mtd partition detection variables local AK3: cleanups and fixes to config/setup functions - simplify rdtmp and $ramdisk creation and keep only in `unpack_ramdisk` - fix `reset_ak` and `setup_ak` behavior if run before $block is set - only save boot.img and boot-new.img in *-files subdirectories on multi-partition setups since otherwise the tmpfs (in recovery) and ext4 .img (when booted) size usage gets quickly out of hand - fix slot_select=inactive when used with block=auto or block=boot partition detection tools: update magisk tools to v19.3(19300) stable AK3: support MTK /dev/bootimg and /dev/recovery partition matching (note these probably require nanddump and nandwrite to access correctly) AK3: resolve non-zero return code introduced by `cat <img> /dev/zero > <block>` - the expected "cat: write error: No space left on device" gives a non-zero return code so always return true - devices that flash dtbo abort since the return code would get passed back to the Backend and silently fail as the final command in anykernel.sh (via `write_boot`), so catch seperately with a proper error message for other image write methods README: updates and touchups for AK3 - bring in line with XDA thread AK3: allow workaround for dtbo devices with cat /dev/zero issues - some device recoveries (e.g. TWRP for wahoo) seem to have issues with the new `cat <image> /dev/zero > <block>` method of flashing, so allow setting customdd="bs=1048576" shell variable in anykernel.sh to work around this by reverting back to dd wipe+flash for dtbo as it does with boot AK3: fix elftool repack cmdline handling README: Update for AK3 anykernel: Update for AK3 tools: rename ak2-core.sh to ak3-core.sh Welcome to AK3: AnyKernel2 + Magisk = AnyKernel3! - abstract out execution directory as $home to fascilitate testing individual scripts (defaults to /tmp/anykernel) - general script clean ups for uniformity, readability, speed and simplicity - simplify consecutive `ui_print` commands where possible README: cosmetic changes to match XDA thread AK2: underp opposite slot case README: update for multi-slot zip instructions AK2: add support for multi-slot zips - extend `reset_ak` with `reset_ak keep` which will keep files to be available to patch the other slot - add optional slot_select=inactive shell variable to force inactive slot during slot detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Starting with API 28 OEMs use ro.product.vendor.device for device name definition in /vendor/build.prop
Xiaomi Mi 8:
https://github.com/TadiT7/xiaomi_dipper_dump/blob/8385f43b85cc3c4f055fff6289776374c4c5d6e9/vendor/build.prop#L18
Xiaomi Mi Mix 2S: https://github.com/TadiT7/xiaomi_polaris_dump/blob/d069dedee55a3fb62d003a3a30a7642cb1d2e295/vendor/build.prop#L18
Google Pixel 2: https://github.com/TadiT7/google_walleye_dump/blob/8033f01f57d9cf11b3b2686c51a4a3e9a4dffaef/vendor/build.prop#L18
OnePlus 6: https://github.com/TadiT7/oneplus_enchilada_dump/blob/d1462ce505d9e70d0288ed4359ef21b998e9edbe/vendor/build.prop#L10
The text was updated successfully, but these errors were encountered: