Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed adaptive Brightness / Overlay applying on Redmi Note 7 #114

Merged
merged 9 commits into from
Aug 22, 2019
Merged

Fixed adaptive Brightness / Overlay applying on Redmi Note 7 #114

merged 9 commits into from
Aug 22, 2019

Conversation

darkestDark
Copy link
Contributor

No description provided.

@darkestDark darkestDark mentioned this pull request Jun 12, 2019
Open
phhusson
phhusson reviewed Jun 12, 2019
View reviewed changes
Xiaomi/RedmiNote7/res/values/notch.xml
@@ -18,8 +18,8 @@
-->
<resources>
<!-- Height of the status bar in portrait -->
<dimen name="status_bar_height_portrait">89px</dimen>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh nope, px are better than do (so that it works when user changes dpi)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no concerns... not looked so far.

@darkestDark darkestDark mentioned this pull request Jun 12, 2019
Open
@darkestDark
Copy link
Contributor Author

finally added the sunset and sunrise time... they werent include.
with vendor fingerprint the overlay wont be applied, idk why. the fingerprint is xiaomi stock vendor. have checked many different ones... no way. the vendor device works ootb.

@phhusson
Copy link
Owner

phhusson commented Aug 5, 2019

I don't understand your last commit.
Those values are original AOSP values, there is no point in changing them...?

Also, this isn't hardware specific, this doesn't belong to device overlay.
You can open a MR in https://github.com/phhusson/device_phh_treble/tree/android-9.0/overlay/frameworks/base/core/res/res if you believe this should be changed in this AOSP ROM.

darkestDark and others added 8 commits August 5, 2019 16:48
@darkestDark @phhusson
Changed Prop
2212309 
With (existing) vendor fingerprint, the overlay wont apply. With this prop, now working.
@darkestDark @phhusson
Fixed brightness slider and autobrightness bug
3c6f05f
@darkestDark @phhusson
Changed Values
71d5b13 
taken from stock framework-res
@darkestDark @phhusson
Update notch.xml
349eb2a
@darkestDark @phhusson
Update config.xml
f14eacd
@phhusson
Revert "Update config.xml"
9010d06 
This reverts commit f14eacd.

This doesn't belong in a device overlay
Also, this is default AOSP values
@phhusson
Don't set dimBehindFadeDuration, this is ROM choice, not hardware-spe…
5692883 
…cific
@phhusson
Add whitelist of keys
4a3a667
@darkestDark
Copy link
Contributor Author

okay...

@phhusson phhusson merged commit 02573f3 into phhusson:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phhusson phhusson phhusson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darkestDark @phhusson