Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better overlay for MI 11 Lite 5G #445

Merged
merged 8 commits into from Jan 20, 2022
Merged

Conversation

danielalmeida1481
Copy link
Contributor

All credits go to @AndroPlus-org

@phhusson
Copy link
Owner

CI result:

I'll allow those:

Fatal: ./Xiaomi/Mi11Lite5G/res/values/config.xml: defines a non-existing attribute config_burnInProtectionMaxRadius
Fatal: ./Xiaomi/Mi11Lite5G/res/values/config.xml: defines a non-existing attribute config_burnInProtectionMinHorizontalOffset
Fatal: ./Xiaomi/Mi11Lite5G/res/values/config.xml: defines a non-existing attribute config_burnInProtectionMaxHorizontalOffset
Fatal: ./Xiaomi/Mi11Lite5G/res/values/config.xml: defines a non-existing attribute config_burnInProtectionMinVerticalOffset
Fatal: ./Xiaomi/Mi11Lite5G/res/values/config.xml: defines a non-existing attribute config_burnInProtectionMaxVerticalOffset

You need to keep the overlay position that was there before your change in overlay.mk:

Fatal: overlay.mk: Keep entries sorted

Those settings don't exist in AOSP:

Fatal: ./Xiaomi/Mi11Lite5G/res/values/config.xml: defines a non-existing attribute config_enableSmartPixels
Fatal: ./Xiaomi/Mi11Lite5G/res/values/config.xml: defines a non-existing attribute config_showHideNotchSettings

This setting doesn't belong to hardware device choice, but to ROM:

Fatal: ./Xiaomi/Mi11Lite5G/res/values/config.xml: defines a non-existing attribute config_camera_sound_forced
Fatal: ./Xiaomi/Mi11Lite5G/res/values/config.xml: defines a non-existing attribute config_ui_enableFadingMarquee

phhusson added a commit that referenced this pull request Jan 19, 2022
@danielalmeida1481
Copy link
Contributor Author

I think it's all fixed now

Xiaomi/Mi11Lite5G-Settings/res/values/config.xml Outdated Show resolved Hide resolved
Xiaomi/Mi11Lite5G-Settings/res/values/config.xml Outdated Show resolved Hide resolved
Xiaomi/Mi11Lite5G-Settings/res/values/config.xml Outdated Show resolved Hide resolved
Xiaomi/Mi11Lite5G-SystemUI/res/values/config.xml Outdated Show resolved Hide resolved
Xiaomi/Mi11Lite5G-SystemUI/res/values/config.xml Outdated Show resolved Hide resolved
@danielalmeida1481
Copy link
Contributor Author

Ok now it should be all fixed

@phhusson phhusson merged commit 1de22ff into phhusson:pie Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants