PSR-4 Autoloading from composer.phar #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSR-4 autoloading packages as well.
|
I think PSR-4 wasnt there when this was built, will this be a bc break in anyway or work with any recent composer? |
|
This should work with any composer.phar, it certainly has with all I've tried includes several from the last 6 months. Definitely works with versions before and after the change that broke stuff. Where I'm not sure is the pervious version didn't include all of the autoloader and I'm not sure if that was deliberate and if this version loading the entire autoloader might cause other issues on the mopa side. |
|
it shouldn't but i need some time to check this ... await merge at latest start of next week |
|
@aashley thanks a lot! |
rjkip
pushed a commit
to OpenConext/Stepup-SelfService
that referenced
this pull request
Nov 12, 2015
rjkip
pushed a commit
to OpenConext/Stepup-RA
that referenced
this pull request
Nov 12, 2015
rjkip
pushed a commit
to OpenConext/Stepup-Gateway
that referenced
this pull request
Nov 12, 2015
This was referenced Nov 12, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a great patch, I don't know why it wasn't done this way originally but it does fix the issues with the PSR-4 dependencies as mentioned in #15 and phiamo/MopaBootstrapBundle#1112
I've only used this with the MopaBootstrap Commands so far so no idea what other knock on effects it might have.