Update to the latest version from CPython 3.8 #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've managed to update this module to the version we currently have in CPython 3.8. The fix for #55 proposed in #56 is also included.
As I explained in #59, some changes might be a little bit backward-incompatible but not in a sense of compatibility with older Pythons but some parts just get deleted in CPython. I haven't seen anything important.
I had to do some small details in different ways or skip a commit or a part of it, here are some notes from the process:
self.hostmask
is still an attribute and not cached property because the same reason as aboveAll tests are okay locally (in Docker containers) so they should be okay also in the CI. Reviews and tests appreciated.