Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version from Python 3.8 #59

Open
frenzymadness opened this issue Nov 18, 2020 · 0 comments
Open

Update to version from Python 3.8 #59

frenzymadness opened this issue Nov 18, 2020 · 0 comments

Comments

@frenzymadness
Copy link

Hello

I'd really like to see #55 fixed and released via #56 but it might be also possible to update this module to the version currently available in Python 3.8 (for start).

I'd like to be proactive here but I need to know what are your plans with backward compatibility. Are you okay to break backward compatibility to stay close to upstream or not? For example, this commit changes how ipaddress handles leading zeros in IPv4 addresses.

I think I've found all commits we have to backport to update to the version we have in Python 3.8 now. The last commit from upstream I see implemented here is python/cpython@91dc64b#diff-f67a8b5be6bdc48383d2ab907325a4c75ef998fa7cd0bba382ec2efa7e4f00b5
The list of commits: https://github.com/python/cpython/commits/3.8/Lib/ipaddress.py
For example, the first commit in the list to backport (python/cpython@58a1096) won't be backported because it uses str.isascii() available only in 3.7 and newer.

Any help appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant