Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Sharing when un-specializing Personal Mii #2

Closed
XT-8147 opened this issue Jan 17, 2017 · 4 comments
Closed

Re-enable Sharing when un-specializing Personal Mii #2

XT-8147 opened this issue Jan 17, 2017 · 4 comments
Labels

Comments

@XT-8147
Copy link

XT-8147 commented Jan 17, 2017

I specialized my Personal Mii just to see what would happen. After nothing bad happened, I un-specialized it and made an identical Mii to specialize instead. However, I can't re-enable Sharing on my Personal Mii from within Mii Maker since it still pops up the dialog saying "Sharing cannot be disabled for your Personal Mii".

@phijor
Copy link
Owner

phijor commented Jan 17, 2017 via email

@phijor phijor added the bug label Jan 17, 2017
@phijor
Copy link
Owner

phijor commented Jan 17, 2017

I implemented re-enabling sharing when unspecializing your Personal Mii locally, would you mind testing if that fixes your issues?

Below is the precompiled application.

SpecializeMii.zip

@XT-8147
Copy link
Author

XT-8147 commented Jan 18, 2017

I apologize for the lateness of my reply.

I had fixed the issue using JKSM to dump the shared extdata and a somewhat buggy Mii editor I found on GBATemp. For testing purposes, I recreated the issue and tested the build you linked with the following steps:

(Testing environment: old3ds a9lh+Luma, 11.2.0-35U sysNAND, using SpecializeMii as an installed CIA)

  1. Back up my CFL_DB.dat using JKSM (personal mii fixed in this one, sharing flag set, copying flag not set, special flag not set)
  2. Open SpecializeMii (the original build I installed from FBI's TitleDB menu), press A on my personal mii and then select followed by A to make it special
  3. Toggle my personal mii back to non-special, press select then A to make it so, and exit
  4. Open Mii Maker, confirm that my personal mii is not special and does not have the sharing flag set. The copying flag is still not set.
  5. I then installed the test build of SpecializeMii linked above with FBI.
  6. Open the test build of SpecializeMii, toggle my personal mii to special, press select then A, toggle it back from being special, press select then A again, then exit.
  7. Open Mii Maker, and now my personal mii has both the sharing and copying flags set, and is not special.

Looks like it works to me. Personally I don't think the copying flag needs to be set when un-specializing the personal mii, the main issue is that Mii Maker will not toggle the sharing flag for a personal mii. It always pops up a dialog saying that sharing can't be turned off, and even if sharing is already off, it doesn't re-enable it.

One thing I noticed while recreating the issue (should I open a separate issue for this?) is that the confirmation on making your personal mii special checks to see if I'm pressing A while I still have A pressed originally, from trying to make it special. The confirmation ever so briefly flashes up on screen before going away (since pressing A confirms it). This is also present in the test build that you linked. I can get the confirmation to stay on screen by very quickly pressing and releasing A, but ideally the confirmation should either wait for the A button to be released and re-pressed, or use a different button.

Thanks for looking into this. I've done work in support before, hence the thorough documentation of my process. Though it doesn't seem necessary now, I can still generate a CFL_DB.dat that contains the issue if it's needed.

@phijor
Copy link
Owner

phijor commented Jan 18, 2017

Thank you very much, that was very detailed and confirmed what I assumed to be the bug.

I will not force the copy-flag if it does not seem to be necessary (as you pointed out). Otherwise, this seems to be ready for a bug-fix release. Thanks again!

If you could open a seperate issue for the prompt not displaying properly, that'd be nice of you.

PS: I you confirmed the test build to be working, I won't need your CFL_DB.dat anymore.

phijor added a commit that referenced this issue Jan 22, 2017
Forcing the copy-flag to be on when un-specializing the personal Mii
does not seem to be necessary for MiiMaker to work properly.

This should fix issue #2.
@phijor phijor closed this as completed Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants