General improvements #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 2, 2014 09:23
- Add "\" to curl-constants (to avoid conflicts in namespaced code)
- Add "\" in doc-blocks
Constructor improvement:
- Enable passing url as only argument, using parse_url to extract the data
Add exceptions in case bad/invalid/incomplete arguments were passed.
Change properties from private to protected Fix bug in constructor (by adding a return statement)
…esponse after create call
…Edited example, to demonstrate usage of generator
…ace + enforce toJsonData method
* feature/composer-notes: Add Note model + addNote call to API wrapper
To support tags, the toJsonData() function was restructured to allow for other data.
This allows individual tags to be set using the addTag() method.
Add support for tags in the Ticket model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken the liberty of forking this repo, and tweak it a bit. I've changed the coding style to be more compliant to the PHP-FIG coding standards.
Return values are, in my opinion, more consistent (methods that return an object, return null instead of false on error).
Exceptions are now thrown when the arguments are malformed/invalid, and debugging is no longer done by simple print-statements. Instead an array is used, which can return or (for now) echo the info.
Constants and classes are qualified in such a way that using this class can't cause issues in a namespaced project.
More complete doc-blocks (in terms of types)
access modifiers have been changed from private to protected to make it easier to extend from this class.