clear additional properties #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear properties for sets country and studio
| @@ -233,7 +233,6 @@ def set_movie_properties(json_response): | |||
| title_header = "[B]" + str(json_response['result']['setdetails']['limits']['total']) + " " + xbmc.getLocalizedString(20342) + "[/B][CR]" | |||
| for item in json_response['result']['setdetails']['movies']: | |||
| art = item['art'] | |||
| streaminfo = media_streamdetails(item['file'].encode('utf-8').lower(), item['streamdetails']) | |||
There was a problem hiding this comment.
Removing those two lines probably wasnt your intention?
There was a problem hiding this comment.
On 3/4/2015 03:37, Philipp Temminghoff wrote:
In Utils.py
#5 (comment):@@ -233,7 +233,6 @@ def set_movie_properties(json_response):
title_header = "[B]" + str(json_response['result']['setdetails']['limits']['total']) + " " + xbmc.getLocalizedString(20342) + "[/B][CR]"
for item in json_response['result']['setdetails']['movies']:
art = item['art']
streaminfo = media_streamdetails(item['file'].encode('utf-8').lower(), item['streamdetails'])Removing those two lines probably wasnt your intention?
—
Reply to this email directly or view it on GitHub
https://github.com/phil65/script.skin.info.service/pull/5/files#r25774238.
Right. I'm just starting to learn github, so probably did something wrong.
scott smart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear properties for sets country and studio
Currently when focus moves from a set to a movie (for example, viewing movie titles with "view movies in sets") , several properties are cleared but Set.Movies.Country and Set.Movies.Studio are not cleared. This PR adds window.clearProperty statements for both of these