DialogPVRChannelsOSD elements missing from on screen display (to master) #221
Conversation
The progress bar and recording icon are not visible in the Live TV on screen channel display for a channel which is currently being recorded. Suggest copying the focussed and item layouts completely (for easier future maintenance) from MyPVRChannels and adjusting the widths accordingly. The scrollbar position then also needs a slight adjustment.
|
Quote: in that case you should move the corresponding code to an include. Sorry, but don't understand, what is an include? Before focussed: After focussed: Before non-focussed: After non-focussed: |
|
@phil65 This PR must also be currently valid for the master version of your skin since your master still contains DialogPVRChannelsOSD.xml ? |
|
@ksooo Your Sidenote for the Krypton PR: Sidenote: Please be aware that in xbmc master DialogPVRChannelsOSD.xml recently got renamed to DialogPVRChannelGuide.xml. => xbmc/xbmc#11554 If I have understood it correctly it is DialogPVRGuideOSD.xml which has been renamed to DialogPVRChannelGuide.xml and not DialogPVRChannelsOSD.xml Therefore this PR is still valid since DialogPVRChannelsOSD.xml has not been renamed and still has the bug. |
Ooops. My fault. You are right. :-) |
The progress bar and recording icon are not visible in the Live TV on screen channel display for a channel which is currently being recorded.
Suggest copying the focussed and item layouts completely (for easier future maintenance) from MyPVRChannels and adjusting the widths accordingly. The scrollbar position then also needs a slight adjustment.