Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change styling of search HUD #1031

Closed
smblott-github opened this issue Apr 20, 2014 · 5 comments
Closed

Change styling of search HUD #1031

smblott-github opened this issue Apr 20, 2014 · 5 comments

Comments

@smblott-github
Copy link
Collaborator

Is there any support for restyling the search HUD?

To me, it's too small and not sufficiently striking. Not to be too disparaging, but the words "weak" and "feeble" come to mind.

Might it not be better to use the same styling as the vomnibar?

@smblott-github
Copy link
Collaborator Author

Suggestions:

  • Make the border bigger and bolder (same as vomnibar).
  • Either use the same font (including size) as the vomnibar, or make the font bold.
  • The No Matches message should be right aligned (and not bold) to visually distinguish it from the search text.

Separately, the HUD currently appears some distance from the right of the page. I understand why this is (it avoids clashes with other popups) but, still, it looks wierd.

@philc
Copy link
Owner

philc commented Apr 20, 2014

Agreed, it needs an overhaul. Let's do this as part of converting it into a
textbox. I'll file a bug for that soon.
On Apr 20, 2014 4:34 AM, "Stephen Blott" notifications@github.com wrote:

Suggestions:

  • Make the border bigger and bolder (same as vomnibar).
  • Either use the same font (including size) as the vomnibar, or make
    the font bold.
  • The No Matches message should be right aligned (and not bold) to
    visually distinguish it from the search text.

Separately, the HUD currently appears some distance from the right of the
page. I understand why this is (it avoids clashes with other popups) but,
still, it looks wierd.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1031#issuecomment-40893052
.

@smblott-github
Copy link
Collaborator Author

Hey, @mrmr1993, do you have any interest in taking a look at this? It would be great to have a consistent and modern look for all of vimium's UI elements.

Excluding the options page, for now -- but we should look at that too, soon.

@mrmr1993
Copy link
Contributor

I don't have any major inspiration for a design change to the HUD. I'm happy to have a go at the code to try and make it an input though.

Before I start, is it going to upset anyone if I put it in an iframe (to avoid hell with selections etc.)?

@smblott-github
Copy link
Collaborator Author

put it in an iframe

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants