Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox warning: InstallTrigger is deprecated and will be removed in the future. #4033

Closed
kashav opened this issue Mar 24, 2022 · 3 comments
Closed

Comments

@kashav
Copy link

kashav commented Mar 24, 2022

Describe the bug
I see this warning in Firefox console on content pages.

InstallTrigger is deprecated and will be removed in the future. utils.js:30:22

To Reproduce
Steps to reproduce the behavior:

  1. Download a recent-ish Firefox Nightly, I'm using 20220322065927.
  2. Install Vimium, perhaps in a fresh profile.
  3. Go to https://example.com or any other website.
  4. Open the console.

Browser and Vimium version

Browser: Firefox Nightly 100.0a1 20220322065927
Vimium: 1.67.1

@kashav
Copy link
Author

kashav commented Mar 24, 2022

Looks like it was deprecated in https://bugzilla.mozilla.org/show_bug.cgi?id=1754441.

Here's the line in Vimium: https://github.com/philc/vimium/blob/master/lib/utils.js#L29-L31.

@davidrunger
Copy link

Here's a permalink to the line in Vimium:

const isFirefox = typeof InstallTrigger !== 'undefined';

@gdh1995
Copy link
Contributor

gdh1995 commented Oct 10, 2022

Just a note: On Firefox 106.0b4, extensions.InstallTrigger.enabled on about:blank is default to false, while 106.0b9 makes it true again (#3774 (comment)).

@philc philc closed this as completed in c5f232c Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants