Don't trigger "InstallTrigger is deprecated and will be removed in the future" warning #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e future" warning By checking for presence in window it doesn't trigger the warning, which is a bit annoying since it's in my console all the time and makes it harder to see "did the script I'm working on throw a warning/error?" at a glance. Furthermore, it also puts back the old check that was removed in #3773; InstallTrigger will be removed eventually, and it will then break for everyone. This conditional should probably be updated, but I don't know what to (and any updated version may have the same issue). Fixes #4033
|
Um, I think a better way to also fix #3773 is check extension URL: typeof browser === "object" && browser.runtime.getURL("").startsWith("moz") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By checking for presence in window it doesn't trigger the warning, which
is a bit annoying since it's in my console all the time and makes it
harder to see "did the script I'm working on throw a warning/error?" at
a glance.
Furthermore, it also puts back the old check that was removed in #3773;
InstallTrigger will be removed eventually, and it will then break for
everyone. This conditional should probably be updated, but I don't know
what to (and any updated version may have the same issue).
Fixes #4033