Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression Bug] v2.1.0 Key exclusion popup #4447

Closed
wenfangdu opened this issue Mar 29, 2024 · 3 comments
Closed

[Regression Bug] v2.1.0 Key exclusion popup #4447

wenfangdu opened this issue Mar 29, 2024 · 3 comments

Comments

@wenfangdu
Copy link

wenfangdu commented Mar 29, 2024

Vimium: 2.1.0

Repro Steps:

  1. Exclude keys for a website and save changes
  2. Visit the website and evoke Vimium popup
  3. It shows no exclusion was configured

image

@philc

@wenfangdu wenfangdu changed the title [Bug] v2.1.0 Exclude keys on page reggresion bug [Regression Bug] v2.1.0 Key exclusion Mar 29, 2024
sudo-nick16 added a commit to sudo-nick16/vimium that referenced this issue Mar 29, 2024
Load tab_recency module before loading bg_utils
in action page.
philc pushed a commit that referenced this issue Mar 29, 2024
Load tab_recency module before loading bg_utils
in action page.
@philc
Copy link
Owner

philc commented Mar 29, 2024

My mistake. It was introduced by the last commit before v2.1.0, and a hard bug to notice (the popup looks like it's still working). Note that existing exclusion rules still apply, and they're still editable on the Vimium Options page, but the popup itself does not function.

I've pushed v2.1.1 to the store which will fix this.

@philc philc changed the title [Regression Bug] v2.1.0 Key exclusion [Regression Bug] v2.1.0 Key exclusion popup Mar 29, 2024
@tammersaleh
Copy link

Note that existing exclusion rules still apply, and they're still editable on the Vimium Options page, but the popup itself does not function.

I think it's worse. Vimium (which I LOVE, btw) is active in Google Docs even though I have that url excluded.

@philc
Copy link
Owner

philc commented Mar 30, 2024

@tammersaleh I confirmed on 2.1.0 that existing exclusion rules will still be applied even though the dialog isn't working, and in particular on docs.google.com. Can you post more details? What is the exclusion rule that you have defined, and what is the URL of your google docs site?

@philc philc closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants