New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Firefox clipboard commands #2601
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5f36adb
FF: Add copy/paste functions to the HUD
mrmr1993 976221f
Initialize the HUD for clipboard operations if it hasn't been already
mrmr1993 5802b33
FF: Add clipboardWrite permission, so we can copy to clipboard
mrmr1993 ac79e75
FF: Use HUD.copyToClipboard for copyCurrentUrl
mrmr1993 fb25b26
FF: Refocus the parent window after focusing the HUD for clipboard ops
mrmr1993 05604d8
FF: Use HUD.copyToClipboard everywhere
mrmr1993 448d609
FF: Use HUD frame for openCopiedUrlIn{Current,New}Tab
mrmr1993 9c1e90b
FF: Add contentEditable to clipboard operation textboxes
mrmr1993 ec95cc2
FF: Show HUD (transparently) when pasting, manage focus changes better
mrmr1993 c8a3954
FF: Use a contenteditable <div> for Clipboard.paste
mrmr1993 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ | |
"bookmarks", | ||
"history", | ||
"clipboardRead", | ||
"clipboardWrite", | ||
"storage", | ||
"sessions", | ||
"notifications", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,5 +95,19 @@ handlers = | |
" (No matches)" | ||
countElement.textContent = if showMatchText then countText else "" | ||
|
||
copyToClipboard: (data) -> | ||
focusedElement = document.activeElement | ||
Clipboard.copy data | ||
focusedElement?.focus() | ||
window.parent.focus() | ||
UIComponentServer.postMessage {name: "unfocusIfFocused", data} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
pasteFromClipboard: -> | ||
focusedElement = document.activeElement | ||
data = Clipboard.paste() | ||
focusedElement?.focus() | ||
window.parent.focus() | ||
UIComponentServer.postMessage {name: "pasteResponse", data} | ||
|
||
UIComponentServer.registerHandler ({data}) -> handlers[data.name ? data]? data | ||
FindModeHistory.init() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might change this to use
mkRepeatCommand
inmain.coffee
(to keep thecount
logic in as few places as possible).