Consider devicePixelRatio when calculating viewport #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix philc#2635, fix philc#2633 and fix philc#2620.
|
I should just merge this without thinking too much, yes? |
I don't know much about HiDPI browsers or |
|
Sorry again for my errors, but this PR is not enough yet - it causes error offsets in such a test:
|
Closed
smblott-github
added a commit
to smblott-github/vimium
that referenced
this pull request
Sep 14, 2017
Mention @mrmr1993. Mention @gdh1995. We have zoom issues resulting from: - style - zoom - --force-device-scale-factor=1.5 - HiDPI This intended to fix HiDPI, but seems to have created problems in the some of the other cases. I don't have time to figure out the problem right now, so I'm going to revert this and push it as 1.60.2. That leaves us pretty much where we were before, I think, in terms of zoom. We can come back to it later.
smblott-github
added a commit
that referenced
this pull request
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2635, fix #2633 and fix #2620.
/cc @smblott-github @gdh1995