Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new "activateMode" option key named "action" #3098

Closed
wants to merge 1 commit into from

Conversation

potpath
Copy link

@potpath potpath commented Aug 19, 2018

Come with 4 actions:

  • focus
  • hover
  • unhover
  • yank-text

This would fix #2188 and #3055.

Come with 4 actions:
- focus
- hover
- unhover
- yank-text

This would fix philc#2188 and philc#3055.
@smblott-github
Copy link
Collaborator

Thanks, @potpath.

This and #3097 do more or less the same thing. I'm minded to prefer #3097 because it requires less plumbing and keeps all of the link-hint mode definitions in one place.

What do you think?

@potpath
Copy link
Author

potpath commented Aug 25, 2018

Thanks for the #3097, just notice that.
I agree on the less changes and the "keep it in one place" for simpler code path.
Will follow the update in #3097 instead. Hope it'll be merged in soon.

@potpath potpath closed this Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Focus hint
2 participants