add 'dblclick' event to simulateClick #3282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would close philc#3281. The rationale behind this is that most places aren't listening for 'dblclick', and the ones that are (https://open.spotify.com is the only one I can find) don't respond to single clicks.
|
Well, the "dblclick" event should not be dispatched by default. We need to care about the events and make them more like the native process. If there's a command option to toggle (enable) it at runtime, it would be better.
Added: I've implemented |
|
Yeah, I agree this PR doesn't make much sense in its current state. I just found this quick fix that works for my purposes, so I thought I'd put it here to illustrate the issue. |
|
Thanks for the commentary. Closing, as this isn't actionable in its current state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would close #3281.
The rationale behind this is that most places aren't listening for
'dblclick', and the ones that are (https://open.spotify.com is the only
one I can find) don't respond to single clicks.