Send mouse events that bubble across shadow DOM #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes clicking on buttons/links in the latest version of Gerrit.
|
LGTM. BTW, although https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/MouseEvent says this constructor only exists on Chrome 47+, in my tests Chrome 31 has supported it. |
|
Nice fix, and readability improvement. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of Gerrit has been redesigned so that the link elements don't actually handle mouse events. They're instead handled by other elements a few layers of shadow DOM up. Events created by initMouseEvent don't have
composedset, so they won't bubble up shadow DOM. This setscomposedusing the MouseEvent constructor.Also initMouseEvent is deprecated according to MDN.
Link: https://fuchsia-review.googlesource.com/