Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regex in find mode #376

Closed
wants to merge 5 commits into from
Closed

Use regex in find mode #376

wants to merge 5 commits into from

Conversation

angelonuffer
Copy link
Contributor

I like regex and the vimium don't have it.
I saw the issue #367 and wanted to contribute.
Have some bugs, but I think it is the begin.
Thats it.

@philc
Copy link
Owner

philc commented Jul 20, 2011

Thanks for taking a stab at this. The code needs to be documented further and any outstanding bugs eliminated before we can pull it in.

@danielb2
Copy link

danielb2 commented Sep 9, 2011

+1

What are the outstanding bugs?

@philc
Copy link
Owner

philc commented Nov 27, 2011

@angelonuffer, you mentioned there are some remaining bugs. What are they? And would you also like to document the code?

@angelonuffer
Copy link
Contributor Author

I'm sorry for the time.. I think the bugs were:

  • n and N are not correct
  • if the regex is not complete (e.g. "^[a-z"), it crashes
    I don't remember anymore bugs.
    Documentation is only the readme and help dialog?

@philc
Copy link
Owner

philc commented Nov 27, 2011

Documentation as in adding comments to the code and renaming variables so that it's more clear what's going on.

@laurent-le-graverend
Copy link

Can't wait for it to be merged!

@int3
Copy link
Collaborator

int3 commented Jan 15, 2012

@angelonuffer: did you delete your fork? I'd be happy to polish it up and merge it in for you, but I can't pull / edit it offline without access to the original repository.

@int3
Copy link
Collaborator

int3 commented Jan 15, 2012

Nevermind -- I added in your changes as a single commit, with you as the author, and I added your name to CREDITS too. I hope that's cool with you. The final implementation was a bit more work, but your idea of grepping textContent seems to be the right approach, and it wasn't something I'd thought of before. Thanks!

The regex-find code is now located on a branch of that name, and should be merged into master soon.

@int3 int3 closed this Jan 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants