New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use regex in find mode #376
Conversation
Thanks for taking a stab at this. The code needs to be documented further and any outstanding bugs eliminated before we can pull it in. |
+1 What are the outstanding bugs? |
@angelonuffer, you mentioned there are some remaining bugs. What are they? And would you also like to document the code? |
I'm sorry for the time.. I think the bugs were:
|
Documentation as in adding comments to the code and renaming variables so that it's more clear what's going on. |
Can't wait for it to be merged! |
@angelonuffer: did you delete your fork? I'd be happy to polish it up and merge it in for you, but I can't pull / edit it offline without access to the original repository. |
Nevermind -- I added in your changes as a single commit, with you as the author, and I added your name to CREDITS too. I hope that's cool with you. The final implementation was a bit more work, but your idea of grepping textContent seems to be the right approach, and it wasn't something I'd thought of before. Thanks! The regex-find code is now located on a branch of that name, and should be merged into master soon. |
I like regex and the vimium don't have it.
I saw the issue #367 and wanted to contribute.
Have some bugs, but I think it is the begin.
Thats it.