avoid triggering popup blocker on some old versions of firefox #4166
Conversation
|
To circumvent the issue that is being fixed by this PR I installed the latest version of the plugin locally and it does not have this issue besides the fact that this PR is not yet merged. Maybe I am running into something differently though.. Edit: sorry, I was wrong, it does not work on master. I checked out |
lib/dom_utils.js
Outdated
| @@ -323,7 +323,7 @@ var DomUtils = { | |||
| // In firefox prior to 96, simulating a click on an element would be blocked. In 96+, | |||
| // extensions can trigger native click listeners on elements. See #3985. | |||
| const mayBeBlocked = event === "click" && Utils.isFirefox() && parseInt(Utils.firefoxVersion()) < 96 | |||
| && /^91\.[0-5](\.|$)/.test(Utils.firefoxVersion()) | |||
| && /^(?!91\.)|^91\.[0-5](\.|$)/.test(Utils.firefoxVersion()) | |||
There was a problem hiding this comment.
This regexp is now pretty complicated to look at, and the comment doesn't indicate why we're checking for Firefox 91.
I think this would be much easier to work with if 1) we added firefoxMajorVersion and firefoxMinorVersion to Utils and used those for comparisons, so we don't have to use parseInt on a string and regexps to parse those out here, and 2) updated the comment to describe why we're checking against Firefox 91 in this section.
There was a problem hiding this comment.
Hello Philc, I've updated the code to make it clear.
1. The old code ignores Firefox versions which are older than 96 while don't belong to 91. 2. On Firefox 91.6+, a plain `click` event on `<a target=_blank>` will still trigger the popup blocker, so this commit avoids it
gdh1995
force-pushed
the
fix-firefox-version-check
branch
from
1869ed0
to
cb78fa5
Compare
gdh1995
changed the title
|
And as I've updated in #3985 (comment) , Firefox 91.6+ still reports "popup-blocked" on a plain Just now I tested the commit cb78fa5 on Firefox 90, 91.0esr, 91.6esr and 96, and it works perfectly whether Firefox's |
|
Much clearer, thanks @gdh1995 |
The old code in #4000 ignores Firefox versions which are older than 96 while don't belong to 91. So this PR adds it.
Should fix #4165 .