Add clipboardRead and clipboardWrite permissions needed for firefox #4186
Conversation
The permissions clipboardRead and clipboardWrite are not needed for chrome using the clipboard api. These were removed in 15ba534 however, they are needed for the clipboard functionality to work in Firefox. Fixes philc#4183
|
It should also fix #4173 for Firefox users. At least the cases that are caused by missing permissions. |
|
Thanks @OmriKaplan ! Not sure how to notify the main devs though 😂🤨 |
|
@philc Sorry to bother you, but we're pasting random stuff for weeks now after yanking from Firefox 😂 |
|
Yes, I see all of the pain across Github issues. It's frustrating that Firefox has different behavior here than Chrome. I've just returned from a long trip without wifi. I'll get this out this weekend. Thank you for the PR.
…On Thu, Dec 15, 2022 at 6:40 AM, Omri Kaplan < ***@***.*** > wrote:
@ philc ( https://github.com/philc ) Sorry to bother you, but we're pasting
random stuff for weeks now after yanking from Firefox 😂
Thanks for the brilliant plugin!
—
Reply to this email directly, view it on GitHub (
#4186 (comment) ) , or unsubscribe
(
https://github.com/notifications/unsubscribe-auth/AAACDFTNDSSZFV5YOJ6ZNEDWNMUVHANCNFSM6AAAAAASVW76OY
).
You are receiving this because you were mentioned. Message ID: <philc/vimium/pull/4186/c1353196998
@ github. com>
|
|
Thank you for this PR! I have been following this issue and was curious to see the fix. I would expect there be a condition that checks if Firefox, then do the stuff you committed, but I am not seeing that. Can you fill me in? What makes this only execute for Firefox? |
|
@mcp292 as you can see here:
The different manifests are written at different times. First it writes one with the settings specific to firefox and zips it naming it as such. Then, it writes again to the same file, but this time without those settings, effectively rewritten the previously written file, and it is now named With this, different zip files are used for different stores, with the specific settings for each. Hopefully that makes sense... |
Thanks for your awesome work! Using this, i3 and vim has helped me to increase my productivity a lot! And my fingers are thankful I don't use the mouse as much. Really appreciate your awesome job! |
philc
changed the title
|
I noticed the permissions added in this PR for firefox were bleeding through to the Chrome build. This is fixed in c0edf21. |
@citosid Thank you! This makes a lot of sense. The answer I'm walking away with is they all execute, and depending on the store, only that zip file is used. Very cool! |
The permissions clipboardRead and clipboardWrite are not needed for chrome using the clipboard api. These were removed in 15ba534 however, they are needed for the clipboard functionality to work in Firefox.
Fixes #4183
Description
The copy/paste functionality in firefox is broken due to missing permissions. This commit adds them back only for firefox.