Allow count prefix for close tabs commands #4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so we can distinguish when a count has actually been given by the user, vs. not.
This was referenced Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to close "just one tab on the right" by adding a prefix to their closeTabsOnRight command.
This has been requested in #2970, #3518, #3345 and probably others.
This PR is a continuation of #2971 and replaces #3853.
Note that it's a bit strange that the default count of closeTabsOnRight is infinity, rather than 1. This was done to preserve existing behavior, and so that users don't have to append count=9999 to their config to implement probably the most common desired behavior which is "close all tabs on right".