New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] support timeout, retry. and fix http request error log #110

Merged

philchia merged 4 commits into philchia:v4 from everywan:v4

Mar 24, 2023

Contributor

everywan commented Mar 22, 2023

No description provided.

everywan added 2 commits

March 22, 2023 19:41


          [feature] support timeout, retry. and fix http request error log

9c58415


          [fix] fix unit test

4b8611f

coveralls commented Mar 22, 2023 •

edited

Pull Request Test Coverage Report for Build 243

30 of 36 (83.33%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 88.943%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
poller.go	2	3	66.67%
client.go	2	7	28.57%

Totals
Change from base Build 240:	-0.3%
Covered Lines:	732
Relevant Lines:	823

💛 - Coveralls


          [fix] fix init bug

833db8d

Contributor Author

everywan commented Mar 24, 2023 •

edited

Hello @philchia

Owner

philchia commented Mar 24, 2023

The retry logic is not covered in tests @everywan


          [fix] add TestRequestWithRetry

5127d32

Contributor Author

everywan commented Mar 24, 2023

Has added.

philchia merged commit 0cddcbf into philchia:v4

Contributor Author

everywan commented Mar 24, 2023 •

edited

可以发一个新版本么? 🙏 @philchia

Contributor Author

everywan commented Mar 27, 2023 •

edited

Hello? @philchia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment