Corrected impl lookup to search whole scope and fixed a bug with tuple/unit structs at end of scope #570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues. Firstly there is an issue where racer could panic when completing on a tuple or unit struct at the end of a scope:
Originally, if one tried to complete on
t.t
, racer would panic since it would try to find fields on the structFoo
, look ahead for an open/close brace and panic when it meets the}
at the end of the Sub module. This is because of anu32
underflow inscopes::find_close
which has now been fixed.Secondly, the completion at
t.t
above would still fail since racer would start searching for implementations from theF
inpub struct Foo(bool)
rather than from the start of the module scope. This has now been fixed and a new test has been added to cover this case.