Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks should support multiple ways to specify packages to check #10

Open
phildini opened this issue Feb 14, 2018 · 2 comments
Open

Thanks should support multiple ways to specify packages to check #10

phildini opened this issue Feb 14, 2018 · 2 comments
Assignees
Projects

Comments

@phildini
Copy link
Owner

From discussion in #pypa on freenode:

It would be great if thanks <package name> just worked, even on packages that weren't installed locally.

@tomdottom
Copy link
Collaborator

@phildini were you thinking of following the pip cli api.

thanks -r requirements.txt
thanks package-name
thanks setup.py

???

@phildini
Copy link
Owner Author

phildini commented May 19, 2018

So, here's my vision for the interface. All of these are listed in "order in which I would like to see them implemented"

  1. thanks with no arguments - looks at the results of pip list, fetches the funding data for everything it finds.
  2. thanks -r requirements.txt - looks only at the requirements.txt, fetches the funding data for what's listed there
  3. thanks {package_name} - fetches the funding data of a single package.

Note, when I say "fetches" here, I mean "should check locally first and then try to optionally hit PyPI"

Deep future:

  1. thanks -p Pipfile - does what thanks -r requirements.txt does, but on a Pipfile
  2. thanks -s setup.py - same, but on a setup.py

@phildini phildini changed the title Thanks should be able to work on an arbitrary package name Thanks should support multiple ways to specify packages to check May 19, 2018
@phildini phildini added this to To do in Thanks May 19, 2018
@tomdottom tomdottom moved this from To do to In progress in Thanks Jun 17, 2018
@tomdottom tomdottom self-assigned this Jun 27, 2018
@tomdottom tomdottom moved this from In progress to Done in Thanks Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Thanks
  
Done
Development

No branches or pull requests

2 participants