Adds Pipfile support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected linting errors and removed rouge 'print' calls. Moved to using nosetest as the setup.py test runner. This is mainly as nose give clearer error messages when something goes wrong. Also of note there were pinned dependencies which have been changed to 'at least' version dependencies. For reasons why see https://caremad.io/posts/2013/07/setup-vs-requirement/ Laster, we currently have a README.md and a README.rst. I'm unsure which one of these we mean to use. Shouldn't we at the very least keep all of the following in the same markup format: README, HISTORY, CONTRIBUTING, AUTHORS,
|
🤔 failing tests. But Will have to return to this when I'm not so 😴 |
phildini
reviewed
Jun 27, 2018
thanks/cli.py
Outdated
| @click.option("--pipfile", "-p", | ||
| multiple=True, | ||
| type=click.File("r")) | ||
| # @click.option("--setuppy", "-s", |
There was a problem hiding this comment.
I think it's good to support these in the future, but would rather not have commented out code lying around. If we want to add a # TODO: Support more types I'm fine with that.
thanks/thanks.py
Outdated
|
|
||
| return '\n'.join(lines) | ||
|
|
||
| def rocks(self, colored_output=True): |
There was a problem hiding this comment.
could we instead call this give or print? I was confused reading this what rocks was referring to.
- thanks.rocks is confusing - removes commented out code
tomdottom
force-pushed
the
thanks-10
branch
2 times, most recently
from
8f72a81
to
35e730b
Compare
- Moves to py.test as gives better error messages
.egg files are sensibly added to .gitignore This is probably one of the very few cases where you want to add a .egg file :)
|
Ok @phildini, anything else? |
phildini
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #18 and implements some of #10
Current usage: