Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dev setup #370

Merged
merged 13 commits into from
Nov 18, 2021
Merged

Improve dev setup #370

merged 13 commits into from
Nov 18, 2021

Conversation

philgyford
Copy link
Owner

  • Changes to Docker set up
  • Use Docker environment in VS Code for linting etc.
  • Remove ./scripts/
  • Add ./run script to make it easier to do things in the Docker environment
  • Add a Docker container for building front-end assets, rather than doing it on the host machine
  • Move source front-end assets to /assets/
  • Use yarn instead of npm to install packages to build front end assets
  • Format all code that doesn't already conform to black, with black
  • Add a black check to the GitHub CI Action
  • Remove runtime.txt (Will Heroku use the python version in Pipfile?

@philgyford
Tweak docker-composer.yml
72a67fc
@philgyford
Add .dockerignore file
a0e5574
@philgyford
Remove .vscode/ from .gitignore
6caf3e4
@philgyford
Use Docker to build static assets with yarn
fb6df7d 
We used to run `gulp watch` etc on the host machine to build the
static assets.

But now we have an extra `assets` docker container in which we
install the necessary Node packages using yarn, and then run
`yarn watch` which, in turn, runs `gulp watch`.

*Seems* to work...
@philgyford
Move source static assets
cfb710f 
Move all the source Sass, CSS and JS files from `hines/static/hines/src/`
to `/assets/`.

It makes them a bit easier to access to edit, and stops a bit of
confusion between these source files and the ones that are actually
used on the site, after build.
@philgyford
Start using the Docker container for VS Code linting etc
fd00808 
https://code.visualstudio.com/docs/remote/containers
@philgyford
Formatting with black
b4661e7
@philgyford
Add black check to GitHub Action
bad5be8
@philgyford
Add more commands to run.sh
6aa812a
@philgyford
Remove scripts directory; move ./scripts/run.sh to ./run
897eb47
@philgyford
Update run script
ae06e89
@philgyford
Try removing runtime.txt; Will Heroku use the pipenv version?
2c188b0
@philgyford
Tweak credit
3ec854c
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.327% when pulling 3ec854c on improve-dev-setup into 27ba26a on main.

@philgyford philgyford merged commit e677849 into main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philgyford @coveralls