Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Error #26

Closed
Rhyfelwr opened this issue Sep 29, 2017 · 4 comments
Closed

Parse Error #26

Rhyfelwr opened this issue Sep 29, 2017 · 4 comments
Assignees

Comments

@Rhyfelwr
Copy link

Convert a file

Parse error: syntax error, unexpected T_FUNCTION, expecting ')' in /opt/lampp/htdocs/MySQLConverterTool-master/Converter.php on line 364

@philip philip self-assigned this Oct 2, 2017
@philip
Copy link
Owner

philip commented Oct 2, 2017

Interesting and surprising, thanks for the report, I'll take a look on Monday.

@philip
Copy link
Owner

philip commented Oct 2, 2017

The code that generates that parse error uses anonymous functions that were added in PHP 5.3. The code was added in change a1dee30 about a year ago, and then updated via a58fc77 a little while later.

It'd make sense for MySQLConverterTool to work in older PHP versions as this converts old MySQL code, so I'll look into this later this week and hopefully make all the code work with old PHP versions again.

Thanks for the report.

@Rhyfelwr
Copy link
Author

Rhyfelwr commented Oct 2, 2017

Hi Philip

I ran this on php Ver 5.2.0 which would explain it!

It’s on an old internal LAMP machine, hence the upgrade in code before we upgrade the platform.

Glad it helped!

@philip philip closed this as completed in dc496d1 Oct 2, 2017
@philip
Copy link
Owner

philip commented Oct 2, 2017

@Rhyfelwr Please give it another try with the latest change (change #dc496d1) and hopefully this fixes the issue. I don't have PHP 5.2 or lower to test right now, but will do so eventually.

@philip philip reopened this Oct 2, 2017
@philip philip closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants