first example for idea extended devices. #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,9 +17,9 @@ module.exports = (env) -> | |||
| init: (app, @framework, @config) => | |||
| deviceConfigDef = require("./led-light-schema") | |||
|
|
|||
| @framework.deviceManager.registerDeviceClass "LedLight", | |||
| @framework.deviceManager.registerDeviceClass "IWYLed", | |||
There was a problem hiding this comment.
MilightLed should be also attached to the framework here!?
There was a problem hiding this comment.
Yes. But please Note. I just made this for The general idea. So i probably broke almost erything with this pull ;)
There was a problem hiding this comment.
Yes, I aware that this is a blueprint. I just wanted to prof that I got it right.
There was a problem hiding this comment.
Yea you got it right ;)
So only The plugin itself is seperate. All of The action providers ect. And The gui is shared
|
I've opened a new PR based on this #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was my idea in general (not tested any code, so i probably broke the plugin with this commit ;))
But here you can see what direction i want to go.
This also seems to be the way pimatic (internally) is set up.
For example. The dimmer class is extending the class of the switch. So you do not have to implement On/Off or Toggle functions. Only 1 change state function and all of the above work as well.
Let me know what you think!