Selenium #12
Merged
Selenium #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in the fix login problem
This API now uses a selenium webdriver to authenticate api requests. Once initialized, the api works as it did before by using the requests library
|
Bumping this to see if this is a reasonable pull request. In previous requests, you've comment on the in ability to validate these changes. If necessary, I can add to this pull request an addition of GitHub actions where users can supply credentials as secure environment variables so that future pull requests can be validated on the end of requestors. |
|
This looks great! Like you said, I can't verify that it works, but it looks good to me. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #11 by updating the API's
__init__function to authenticate using a headless browser using selenium. The selenium WebDriver can be supplied as one of the arguments to the__init__function, though the default uses of headless chrome browser.All tests have been updated to the key lists that are currently returned to ensure tests pass.