Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for update LCR changes #7

Merged
merged 6 commits into from
Apr 21, 2021
Merged

Fix for update LCR changes #7

merged 6 commits into from
Apr 21, 2021

Conversation

kevincar
Copy link
Contributor

pytest was recently failing. These changes should get it up again. I believe these changes may address #6

@kevincar
Copy link
Contributor Author

kevincar commented Jul 28, 2019

After further review, this pull request may be premature. The changes I made to get the member_list function working essentially changes the request URL to the same URL used in the members_alt function. I hadn't noticed that function previously

It does appear, however, that this link references a resource that is no longer active as seen in #6.

Observing the XHR requests while making a request for the "Member List" report on LCR shows that the site now uses this url aka the members_alt function, which includes the umlu portion of the url.

Either way. At the present time LCR seems to be using the members_alt associated URL in place of the member_list url for the time being, and the request URL used in the member_list function isn't in use.

Pull in the fix login problem
@philipbl
Copy link
Owner

Before I merge this, I want to make sure of the change (I don't have access to LCR anymore, so I can't verify it myself). The current members_list() function does not work so you updated the URL to fix it?

@flakeman2
Copy link

Any update on this? @philipbl I'd really like to use this library. If you need, I could lend you access to my account for testing (you seem like an honest guy ;) )

@philipbl philipbl merged commit 756d2b8 into philipbl:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants