Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add duplex streams #48

Merged
merged 2 commits into from
May 11, 2019
Merged

feat: Add duplex streams #48

merged 2 commits into from
May 11, 2019

Conversation

philipjscott
Copy link
Owner

Context

Some stream APIs expect duplex stream support, such that you can create data pipelines, eg.
a | b | c > d. simple-thumbnail does not provide a way to get a duplex stream.

Objective

genThumbnail(null, null, '250x?') // Returns duplex stream

Why the double nulls? To keep it consistent with the existing API.

References

Issue: #47

@philipjscott philipjscott merged commit bbe0076 into master May 11, 2019
@philipjscott philipjscott deleted the duplex branch May 11, 2019 07:15
@philipjscott
Copy link
Owner Author

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant