Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures in test_deprecations.py with django-filter 0.14 #106

Closed
edmorley opened this issue Sep 8, 2016 · 1 comment
Closed

Failures in test_deprecations.py with django-filter 0.14 #106

edmorley opened this issue Sep 8, 2016 · 1 comment

Comments

@edmorley
Copy link
Contributor

edmorley commented Sep 8, 2016

The changes in #101 were passing when the PR was opened:
https://travis-ci.org/philipn/django-rest-framework-filters/builds/149494990

However failed once merged to master, under Python 3.4/3.5 only:
https://travis-ci.org/philipn/django-rest-framework-filters/builds/158502234

No other changes landed between the two, so it must be due to external unpinned dependencies changing.

Looking at the logs I see the former used django-filters 0.13, and the latter 0.14. The changes between the two are:
carltongibson/django-filter@v0.13...0.14.0
...which includes some new deprecations.

@rpkilby
Copy link
Collaborator

rpkilby commented Sep 8, 2016

Yep the 0.14.0 deprecations would explain it, although I'm confused about why this only affects the python 3.4 and 3.5 builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants