Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what's happening if dilations=None #34

Closed
Luux opened this issue Jan 7, 2019 · 3 comments
Closed

Clarify what's happening if dilations=None #34

Luux opened this issue Jan 7, 2019 · 3 comments

Comments

@Luux
Copy link

Luux commented Jan 7, 2019

"dilations" is treated as an optional argument that defaults to "None": tcn.TCN(nb_filters=64, kernel_size=2, nb_stacks=1, dilations=None, activation='norm_relu', padding='causal', use_skip_connections=True, dropout_rate=0.0, return_sequences=True, name='tcn')

In the readme, it only states "List. A dilation list. Example is: [1, 2, 4, 8, 16, 32, 64]."
and in the __call__ function of tcn.py it seams that it gets converted to [1, 2, 4, 8, 16, 32, 64] when it's set to None.

In this case, I think it it should either default to [1, 2, 4, 8, 16, 32] directly instead of None or it should at least be stated in the docs that it behaves so since it's quite confusing this way. Or did i miss something?

@philipperemy
Copy link
Owner

@Luux good catch. I'm going to update that.

@philipperemy
Copy link
Owner

There's a PR here: #35
I'm testing it on GPUs. When it's ready, I'll merge it.

@philipperemy
Copy link
Owner

Done. Keras 2.3.5 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants