Skip to content

Commit

Permalink
Remove ":latest" suffix from images
Browse files Browse the repository at this point in the history
Fixes issue for PostgreSQL image where we already use ":alpine" tag
  • Loading branch information
philippgille committed Dec 3, 2023
1 parent 975002f commit d09f507
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions magefiles/test.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ func testImpl(impl string) (err error) {
// For them we skip the Docker stuff but still execute the tests, which can skip on connection error and we can see the skips in the test results.
if dockerImage != "" {
// Pull Docker image
fmt.Printf("Pulling Docker image %s:latest...", dockerImage)
fmt.Printf("Pulling Docker image %s...", dockerImage)
var out string
out, err = script.Exec("docker pull " + dockerImage + ":latest").String()
out, err = script.Exec("docker pull " + dockerImage).String()
if err != nil {
// Depending on the error, printing the output could be interesting, as it could be more info than what's in err.
fmt.Println(out)
Expand Down

0 comments on commit d09f507

Please sign in to comment.